| Project: | Trisquel |
| Version: | 7.0 |
| Component: | Gnome |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Using the latest (6 August 2014) packages on belenos, there are still a few minor glitches in the Trisquel gtk theme, especially on gnome-panel:
* the text showing the date is white, which is fine on the dark background, but as soon as it's selected, the background becomes white and makes the text unreadable: maybe it should be turned dark?
* on the user menu gnome-panel widget, the bullet to select available/busy keeps a dark background when the cursor goes over it, while it should probably inherit the background from its parent (blue in that case).
Thanks for the great work that has been put in the Trisquel theme already, it really looks nice!
Here is a diff that fixes both issues. For the first issue, I just changed the text color to a value that is more visible on the white background.
In addition, here is the same diff with the radio and check images turned white when non-active as well (that fits better with the dark background).
Another version with the trisquel logo visible in the menu bar (next to the Applications menu title)
Another version with the panel menu bar items background turned to the same blue as menus. This solves the issue with poor lisibility with a white font at the same time and looks nice.
This was done in a way too generic way and impacted other unlrelated things. Here is a version that ensures only gnome-panel is affected by these changes!
Excelent! Applied in trisquel-gtk-theme_7.0-5
I'm afraid you forgot this line:
it is important for the menu bar (the one with Applications and Places).
I'll have other patches pretty soon to:
* have a bigger trisquel icon next to "Applications" (if possible)
* fix unity-greeter theming
Regarding the bigger icon next to Applications in the panel, it should be themable using "gtk-icon-sizes = panel-menu-bar=24,24" in settings.ini but gtk dropped that feature in 3.10, which is the version used in Trisquel 7: https://developer.gnome.org/gtk3/stable/GtkSettings.html#GtkSettings--gtk-icon-sizes
So the bottomline is that the only way to achieve this is to patch the source code.
I don't really mind having the icon 16x16 anyways, but if you want it to look like previous Trisquel versions, the change in gnome-panel is:
Regarding the missing line, here is a proper diff:
diff --git a/gtk-3.0/gtk-widgets.css b/gtk-3.0/gtk-widgets.css index ed6c9c3..296be71 100644 --- a/gtk-3.0/gtk-widgets.css +++ b/gtk-3.0/gtk-widgets.css @@ -3649,6 +3649,7 @@ PanelApplet > GtkMenuBar { -PanelMenuBar-icon-visible: true; } +.gnome-panel-menu-bar.menubar .menuitem:hover, PanelApplet .menubar .menuitem:hover {In order to make the Trisquel theme work correctly in LightDM:
trisquel-gtk-theme:
diff --git a/gtk-3.0/gtk-widgets.css b/gtk-3.0/gtk-widgets.css index 296be71..35c9243 100644 --- a/gtk-3.0/gtk-widgets.css +++ b/gtk-3.0/gtk-widgets.css @@ -3584,7 +3584,9 @@ GtkBubbleWindow .toolbar { PanelToplevel .menu , PanelApplet .menu, PanelToplevel .menu .menuitem, PanelApplet .menu .menuitem, PanelToplevel .menu GtkArrow, PanelApplet .menu GtkArrow, -PanelApplet .menu GtkCalendar, PanelApplet .menu GtkCalendar GtkWidget +PanelApplet .menu GtkCalendar, PanelApplet .menu GtkCalendar GtkWidget, +.lightdm .menubar .menuitem .menu, +.lightdm .menubar .menuitem .menuitem { background-color: #333; border-color: #333; @@ -3595,7 +3597,8 @@ text-shadow: 0px 1px alpha (#000, 0.5); PanelToplevel .menu .separator, -PanelApplet .menu .separator +PanelApplet .menu .separator, +.lightdm .menubar > .menuitem .menu .separator { color:#444; } @@ -3649,8 +3652,8 @@ PanelApplet > GtkMenuBar { -PanelMenuBar-icon-visible: true; } -.gnome-panel-menu-bar.menubar .menuitem:hover, -PanelApplet .menubar .menuitem:hover +PanelApplet .menubar .menuitem:hover, +.lightdm.menubar .menuitem:hover { text-shadow: 0px 1px alpha (#000, 0.3); @@ -3661,14 +3664,29 @@ text-shadow: 0px 1px alpha (#000, 0.3); } +PanelApplet .menubar .accelerator, +.lightdm.menubar .accelerator { + color:#eee; +} + +.lightdm.menubar > .menuitem { + background-image: none; + background-color: transparent; + color: white; +} + .gnome-panel-menu-bar.menubar .menuitem.check:active, -PanelApplet .menubar .menuitem.check:active { +PanelApplet .menubar .menuitem.check:active, +.lightdm.menubar .menuitem.check:active { background-image: url("assets/menuitem-checkbox-checked-selected.svg"); + background-color: transparent; } .gnome-panel-menu-bar.menubar .menuitem.radio:active, -PanelApplet .menubar .menuitem.radio:active { +PanelApplet .menubar .menuitem.radio:active, +.lightdm.menubar .menuitem.radio:active { background-image: url("assets/menuitem-radio-checked-selected.svg"); + background-color: transparent; } .gnome-panel-menu-bar.menubar .menu, @@ -3746,3 +3764,58 @@ GsmFailWhaleDialog .button:active { border-width: 1px; } +/*********** + * LightDM * + ***********/ + +.lightdm * { + background-image: none; + background-color: transparent; +} + +.lightdm.menubar { + background-image: none; + background-color: alpha (black, 0.5); +} + +.lightdm.button, +.lightdm.button:hover, +.lightdm.button:active, +.lightdm.button:active:focused, +.lightdm.entry, +.lightdm.entry:hover, +.lightdm.entry:active, +.lightdm.entry:active:focused { + background-image: none; + border-image: none; +} + +.lightdm-combo.combobox-entry .button, +.lightdm-combo .cell, +.lightdm-combo .button, +.lightdm-combo .entry, +.lightdm.button, +.lightdm.entry { + background-image: none; + background-color: alpha (black, 0.3); + border-color: alpha (white, 0.6); + border-radius: 5px; + padding: 7px; + + color: white; + text-shadow: none; +} + +.lightdm.button:focused, +.lightdm.entry:focused { + -unico-focus-border-color: alpha (white, 0.9); + border-color: alpha (white, 0.9); + border-width: 1px; + border-style: solid; + + color: white; +} + +.lightdm.entry:selected { + background-color: alpha (white, 0.2); +}unity-greeter:
diff --git a/com.canonical.unity-greeter.gschema.xml b/com.canonical.unity-greeter.gschema.xml index 3d01830..b797d14 100644 --- a/com.canonical.unity-greeter.gschema.xml +++ b/com.canonical.unity-greeter.gschema.xml @@ -30,7 +30,7 @@ Background logo file to use - 'Ambiance' + 'Trisquel' GTK+ theme to use @@ -38,7 +38,7 @@ Icon theme to use - 'Sans 11' + 'Sans 8' Font to useIn addition, the GTK default theme is still the Ubuntu one, so I suggest this:
/etc/gtk-3.0/settings.ini:
the Ubuntu themes are still installed by default by the way, maybe it's not worth keeping them anymore!
Applied to:
trisquel-gtk-theme_7.0-7
trisquel-desktop-common-data_7.0-15 (/etc/gtk-3.0/settings.ini)
unity-greeter_14.04.10-0ubuntu1+7.0trisquel13
Many thanks!
Automatically closed -- issue fixed for 2 weeks with no activity.