[GFSD Issue] Compizconfig-settings-manager recomends non-free software as a workaround (fglrx)

Project:Trisquel
Version:5.5
Component:Programs
Category:bug report
Priority:blocking
Assigned:SirGrant
Status:patch (ready)
Description
AndrewT:

Changing this might require recompiling all of compiz. I'm not a programmer, so I am not sure.

But merely mentioning fglrx doesn't amount to a recommendation of its use.

27 April, 2010 - 18:58
SirGrant:
Version:3.5» 5.0
Priority:minor» critical

This issue is still active in 5.0

I am marking as critical because it is in fact recommending non-free software. This is in the "workarounds" section and the string says "Fix screen updates in XGL with fglrx" basically saying that you can fix the problem with non-free software. This option needs to be removed from the program.

1 April, 2012 - 00:50
SirGrant:
Title:CompizConfig Settings Manager mentions fglrx» CompizConfig Settings Manager recomends non-free software as a workaround (fglrx)

Changing the title of the bug to better reflect the bug.

1 April, 2012 - 01:02
SirGrant:
Title:CompizConfig Settings Manager recomends non-free software as a workaround (fglrx)» compizconfig-settings-manager recomends non-free software as a workaround (fglrx)

Altering the title one more time to reflect the specific package affected.

1 April, 2012 - 01:27
SirGrant:
Version:5.0» 5.5

Ok, I have started looking at the source code for this program and I was using grep to search for fglrx and came up with absolutely nothing.

I then looked in the compiz-plugins package which is a dependency and am finding some hits:

$ grep -i 'fix screen updates in xgl with fglrx' -r compiz-plugins-main-0.9.6/

compiz-plugins-main-0.9.6/workarounds/workarounds.xml.in: <_short>Fix screen updates in XGL with fglrx.

I think we can just remove that line and have it work. I'll give it a shot and report back.

Edit: I just found out basically it is an XML file and compiz-settings-manager just reads these files to display it's options. I am going to write a package helper to comment out or remove these lines.

6 June, 2012 - 16:32
SirGrant:
Assigned to:anonymous» SirGrant

Ok, I know what needs to be fixed/change I just don't know how to do it. I am going to visit my dad in ~2 weeks and he is really good at this stuff and he said he would help me. I'm assigning this issue to myself and should hopefully have a fix when I go to visit him.

10 June, 2012 - 22:26
SirGrant:
Status:active» patch (ready)

I am on vacation with my family but my Dad wrote a package-helper for this one while teaching me some things. I have attached the package helper (as a .txt file) and will email it to the devel list as soon as I get home.

Edit: devel-list post

AttachmentSize
make-compiz-plugins-main.txt 2.99 KB
3 July, 2012 - 01:43
SirGrant:
Title:compizconfig-settings-manager recomends non-free software as a workaround (fglrx)» [GFSD Issue] Compizconfig-settings-manager recomends non-free software as a workaround (fglrx)
30 October, 2012 - 18:44
SirGrant:
Priority:critical» blocking
6 February, 2013 - 19:33