Home » Trisquel » Problemi
Inviato da Legimet il Sab, 01/11/2014 - 16:49

Abrowser looks ugly in KDE

Progetto:Trisquel
Versione:7.0
Componente:Packages
Categoria:segnalazione di bug
Priorità:normal
Assigned:Legimet
Stato:closed
Descrizione

Abrowser looks ugly in KDE with the gtk2-engines-oxygen package. Apparently this package does some special things for XUL apps such as Firefox and Thunderbird.

An easy fix is as follows:
In the gtk2-engines-oxygen package, go to src/oxygenapplicationname.cpp, and insert the string "abrowser" into the array XulAppNames (at line 74). This fixed the problem for me.

I have attached a screenshot of Abrowser before patching gtk2-engines-oxygen, and after patching it.

AllegatoDimensione
before.png360.26 KB
after.png355.91 KB
Legimet:
Gio, 01/16/2014 - 19:13

The following line should work for a package helper:
sed '76i \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \"abrowser\"\,' -i src/oxygenapplicationname.cpp

Legimet:
Mar, 01/21/2014 - 01:44
Stato:active» patch (needs review)
BugRep:
Mer, 01/22/2014 - 00:05

If some lines were to be added to the file before the 76th line by upstream, the file would have errors. It would be better not to use hardcoded line numbers.

FILE=src/oxygenapplicationname.cpp
LINENUM=$(grep -n '"firefox",' $FILE | cut -d: -f1)
sed -i $LINENUM'i \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \ \"abrowser\"\,' $FILE
Legimet:
Ven, 04/18/2014 - 21:21
Assegnato a:anonymous» Legimet

A patch for this can be found here.

Legimet:
Mer, 05/28/2014 - 02:03

With the upcoming change from Abrowser to Icecat, this patch won't be necessary because "icecat" is already in that array. Once Trisquel switches to IceCat I'll close this issue.

quidam:
Mer, 05/28/2014 - 02:56
Stato:patch (needs review)» fixed

Added to helpers and available in the repos now. Sorry for the delay, and thanks for the contribution!

quidam:
Mer, 06/11/2014 - 03:00
Stato:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

Legimet:
Ven, 12/05/2014 - 01:20
Versione:6.0» 7.0
Stato:closed» patch (needs review)

I've been using the version in my PPA, but I just realized that it needs to fixed in Trisquel 7 as well (since Abrowser is still being used).

Legimet:
Ven, 12/05/2014 - 18:15

Fixed.

SirGrant:
Dom, 12/14/2014 - 14:23
Stato:patch (needs review)» fixed
quidam:
Dom, 12/28/2014 - 14:25
Stato:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.