[GFSD Issue] Compizconfig-settings-manager recomends non-free software as a workaround (fglrx)

Progetto:Trisquel
Versione:6.0
Componente:Programs
Categoria:segnalazione di bug
Priorità:blocking
Assigned:SirGrant
Stato:patch (ready)
Descrizione

Screenshot: http://omploader.org/vNGFnNg/compizconfig-settings-manager-fglrx-mentioning.png

Mar, 04/27/2010 - 18:58

Changing this might require recompiling all of compiz. I'm not a programmer, so I am not sure.

But merely mentioning fglrx doesn't amount to a recommendation of its use.

Dom, 04/01/2012 - 00:50
Versione:»
Priorità:minor» critical

This issue is still active in 5.0

I am marking as critical because it is in fact recommending non-free software. This is in the "workarounds" section and the string says "Fix screen updates in XGL with fglrx" basically saying that you can fix the problem with non-free software. This option needs to be removed from the program.

Dom, 04/01/2012 - 01:02
Titolo:CompizConfig Settings Manager mentions fglrx» CompizConfig Settings Manager recomends non-free software as a workaround (fglrx)

Changing the title of the bug to better reflect the bug.

Dom, 04/01/2012 - 01:27
Titolo:CompizConfig Settings Manager recomends non-free software as a workaround (fglrx)» compizconfig-settings-manager recomends non-free software as a workaround (fglrx)

Altering the title one more time to reflect the specific package affected.

Mer, 06/06/2012 - 16:32
Versione:»

Ok, I have started looking at the source code for this program and I was using grep to search for fglrx and came up with absolutely nothing.

I then looked in the compiz-plugins package which is a dependency and am finding some hits:

$ grep -i 'fix screen updates in xgl with fglrx' -r compiz-plugins-main-0.9.6/

compiz-plugins-main-0.9.6/workarounds/workarounds.xml.in: <_short>Fix screen updates in XGL with fglrx.

I think we can just remove that line and have it work. I'll give it a shot and report back.

Edit: I just found out basically it is an XML file and compiz-settings-manager just reads these files to display it's options. I am going to write a package helper to comment out or remove these lines.

Dom, 06/10/2012 - 22:26
Assegnato a:anonymous» SirGrant

Ok, I know what needs to be fixed/change I just don't know how to do it. I am going to visit my dad in ~2 weeks and he is really good at this stuff and he said he would help me. I'm assigning this issue to myself and should hopefully have a fix when I go to visit him.

Mar, 07/03/2012 - 01:43
Stato:active» patch (ready)

I am on vacation with my family but my Dad wrote a package-helper for this one while teaching me some things. I have attached the package helper (as a .txt file) and will email it to the devel list as soon as I get home.

Edit: devel-list post

AllegatoDimensione
make-compiz-plugins-main.txt 2.99 KB
Mar, 10/30/2012 - 18:44
Titolo:compizconfig-settings-manager recomends non-free software as a workaround (fglrx)» [GFSD Issue] Compizconfig-settings-manager recomends non-free software as a workaround (fglrx)
Mer, 02/06/2013 - 19:33
Priorità:critical» blocking
Ven, 06/12/2015 - 04:09

I pushed your helper to the current system, and fixed an issue with paths in current version

Merge request is here:
https://devel.trisquel.info/trisquel/package-helpers/merge_requests/99#note_621

Gio, 06/25/2015 - 22:26
Versione:» 6.0

Fixed in belenos, but not in toutatis.