Home » Trisquel » Problemi
Inviato da Legimet il Sab, 12/14/2013 - 06:42

[GFSD] sane-backends contains code under original Artistic License

Progetto:Trisquel
Versione:7.0
Componente:License problems
Categoria:segnalazione di bug
Priorità:critical
Assigned:leny2010
Stato:closed
Descrizione

The sane-backends source package contains a file lib/snprintf.c licensed under Artistic License 1.0. The file seems to contain a replacement for snprintf on systems that don't have it. Obviously this file is not needed in Trisquel.

lembas:
Sab, 12/14/2013 - 09:59
Stato:active» needs more info

There isn't a sane-backends package.

Legimet:
Sab, 12/14/2013 - 20:52
Stato:needs more info» active

sane-backends is a source package (part of the sane scanner package).

http://packages.trisquel.info/source/toutatis/sane-backends

lembas:
Dom, 12/15/2013 - 12:47

Oh! Sorry for the bad noise. I thought binary packages would have similarly named source packages 1:1. Thanks for teaching me.

Confirming the reported license problem.

Legimet:
Dom, 12/15/2013 - 22:35

I also found that sane-frontends, sane-backends-extra, and xsane have the same file under version 1.0 of the Artistic License.

Maybe we should do a search for the Artistic License. It seems problematic since Debian considers it free.

lembas:
Mar, 12/31/2013 - 10:09

I'll go ahead and do just that.

Legimet:
Sab, 04/19/2014 - 20:41

We could use the gpl-licensed version in Gnulib (http://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=summary, lib/c-snprintf.c). This is better than just removing it; what if someone tries to compile the version in trisquel for an embedded system without snprintf?

mejiko:
Gio, 05/29/2014 - 08:58

I reported this bug from Fedora and Trisquel.

Trisquel:

sane-frontends: https://trisquel.info/en/issues/11795
xsane: https://trisquel.info/en/issues/11794
sane-backends-extras: https://trisquel.info/en/issues/11793

Fedora:

sane-backends: https://bugzilla.redhat.com/show_bug.cgi?id=1102520
sane-frontends: https://bugzilla.redhat.com/show_bug.cgi?id=1102522
xsane: https://bugzilla.redhat.com/show_bug.cgi?id=1102523

spotrh:
Gio, 05/29/2014 - 17:41

Here are the patches we used to resolve this issue in Fedora (also sent upstream), see: https://alioth.debian.org/tracker/index.php?func=detail&aid=314700

Basically, the lib/snprintf.c code came from an old version of LPRng, so I checked to see if the current LPRng code had it as well, and it had a newer version under a Free license (and a permissive one at that). A few minor edits and we have replacement files for xsane, sane-frontends, and sane-backends.

AllegatoDimensione
xsane-0.999-update-to-current-lprng-plp_snprintf.patch 47.54 KB
sane-frontends-1.0.14-update-to-current-lprng-plp_snprintf.patch 47.57 KB
sane-backends-1.0.24-update-to-current-lprng-plp_snprintf.patch 47.52 KB
Legimet:
Gio, 05/29/2014 - 22:52

Thanks spotrh for the patches!
I will try to make package helpers for this and submit to trisquel-dev.

Legimet:
Ven, 05/30/2014 - 04:18
Stato:active» patch (needs review)
leny2010:
Mer, 12/17/2014 - 01:27
Assegnato a:anonymous» leny2010
Stato:patch (needs review)» patch (needs work)

Patch plainly declined. I've opened DI https://devel.trisquel.info/leny2010/package-helpers/issues/7 to track my rework.

leny2010:
Mar, 12/23/2014 - 06:38
Versione:6.0» 7.0
Stato:patch (needs work)» patch (ready)

Still in 7.0

Reworked patch accepted
https://devel.trisquel.info/trisquel/package-helpers/commit/6a723214a5b85ab9c39854b055c0bdbd45fbcfb8
Awaiting build.

Thank you for your continuing contributions all.

leny2010:
Mer, 01/07/2015 - 15:55
Stato:patch (ready)» needs more info

Update now in Belenos repos. Please comment is you dissent from Fixed status/

aklis:
Gio, 01/08/2015 - 04:34
Stato:needs more info» fixed

Changes were merged into trisquel and package is now updated

quidam:
Gio, 01/22/2015 - 04:35
Stato:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.